Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change expected order of items in the webp_uploads_content_image_mimes filter #250

Merged
merged 2 commits into from Mar 22, 2022
Merged

Change expected order of items in the webp_uploads_content_image_mimes filter #250

merged 2 commits into from Mar 22, 2022

Conversation

eugene-manuilov
Copy link
Contributor

Summary

Fixes #237

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@eugene-manuilov eugene-manuilov added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images Issues related to the Images focus area [Module] WebP Support Issues for the WebP Support module labels Mar 22, 2022
@eugene-manuilov eugene-manuilov added this to the 1.0.0-beta.4 milestone Mar 22, 2022
@eugene-manuilov eugene-manuilov mentioned this pull request Mar 22, 2022
Closed
@eclarke1 eclarke1 added the Needs Review Anything that requires code review label Mar 22, 2022
felixarntz
felixarntz approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eugene-manuilov Great, thanks!

@felixarntz felixarntz requested a review from mitogh March 22, 2022 21:01
@felixarntz felixarntz changed the title Enhancement/237 change order for content mime types Change expected order of items in the webp_uploads_content_image_mimes filter Mar 22, 2022
@felixarntz felixarntz merged commit 34fcb78 into trunk Mar 22, 2022
@felixarntz felixarntz deleted the enhancement/237-change-order-for-content-mime-types branch March 22, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@mitogh mitogh mitogh approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@getsource getsource Awaiting requested review from getsource

Assignees
No one assigned
Labels
[Focus] Images Issues related to the Images focus area [Module] WebP Support Issues for the WebP Support module Needs Review Anything that requires code review [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

Decide on order of webp_uploads_content_image_mimes filter items
4 participants
@eugene-manuilov @felixarntz @mitogh @eclarke1