Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only update the specified target images when an image is edited. #301

Merged
merged 14 commits into from
May 12, 2022
Merged

Only update the specified target images when an image is edited. #301

merged 14 commits into from
May 12, 2022

Commits on Apr 14, 2022

  1. Add assertions for target type of edits 

    When an edit with a target occurrs make sure that only the specified
images are modified, and the metadata reflects this changes based on
the specified target from the media section
    @mitogh
    mitogh committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    a3dee98 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. Merge branch 'trunk' into feature/update-secondary-image-onedit-with-… 

    …targets
    @mitogh
    mitogh committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    04d1676 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2022

  1. Merge branch 'trunk' into feature/update-secondary-image-onedit-with-… 

    …targets
    @mitogh
    mitogh committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    a278dad View commit details
    Browse the repository at this point in the history

  2. Migrate tests to verify image edits to new file location 

    Move the tests from the single location into the correct
file where the image edits are located.
    @mitogh
    mitogh committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    7a36d1d View commit details
    Browse the repository at this point in the history

  3. Handle the scenario when a target is selected. 

    When an image is selected for a target make sure that only
the selected target images are processed instead of processing
all the images when is not required or desired.

Fixes #299
    @mitogh
    mitogh committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    5ecffc8 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2022

  1. Replace regular expression with substr call instead. 

    Co-authored-by: Eugene Manuilov <manuilov@google.com>
    @mitogh @eugene-manuilov
    mitogh and eugene-manuilov committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    20c45d1 View commit details
    Browse the repository at this point in the history

  2. Escape correctly the back slash \

    @mitogh
    mitogh committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    10256c6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'trunk' into feature/update-secondary-image-onedit-with-… 

    …targets
    @mitogh
    mitogh committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    129706f View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Update modules/images/webp-uploads/image-edit.php 

    Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
    @mehulkaklotar @felixarntz
    mehulkaklotar and felixarntz committed May 12, 2022
    Configuration menu
    Copy the full SHA
    91427d2 View commit details
    Browse the repository at this point in the history

  2. Update modules/images/webp-uploads/image-edit.php 

    Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
    @mehulkaklotar @felixarntz
    mehulkaklotar and felixarntz committed May 12, 2022
    Configuration menu
    Copy the full SHA
    fb8d988 View commit details
    Browse the repository at this point in the history

  3. Update modules/images/webp-uploads/image-edit.php 

    Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
    @mehulkaklotar @felixarntz
    mehulkaklotar and felixarntz committed May 12, 2022
    Configuration menu
    Copy the full SHA
    d71045f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' into feature/update-secondary-image-onedit-with-… 

    …targets

# Conflicts:
#	modules/images/webp-uploads/image-edit.php
    @mehulkaklotar
    mehulkaklotar committed May 12, 2022
    Configuration menu
    Copy the full SHA
    f432f4c View commit details
    Browse the repository at this point in the history

  5. PR feedback - check for WP_Error returned added

    @mehulkaklotar
    mehulkaklotar committed May 12, 2022
    Configuration menu
    Copy the full SHA
    fa7edad View commit details
    Browse the repository at this point in the history

  6. test case fixed, to converted

    @mehulkaklotar
    mehulkaklotar committed May 12, 2022
    Configuration menu
    Copy the full SHA
    3643b94 View commit details
    Browse the repository at this point in the history