New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct label for persistent object cache Site Health check #329
Merged
felixarntz
merged 2 commits into
WordPress:trunk
from
mukeshpanchal27:fix/label-persistent-object-cache
May 10, 2022
Merged
Correct label for persistent object cache Site Health check #329
felixarntz
merged 2 commits into
WordPress:trunk
from
mukeshpanchal27:fix/label-persistent-object-cache
May 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethanylang
added
[Type] Bug
An existing feature is broken
[Focus] Object Cache
Issues related to the Object Cache focus area
labels
May 9, 2022
bethanylang
added
no milestone
PRs that do not have a defined milestone for release
[Type] Enhancement
A suggestion for improvement of an existing feature
and removed
[Type] Bug
An existing feature is broken
labels
May 9, 2022
tillkruss
approved these changes
May 9, 2022
tillkruss
added
[Type] Bug
An existing feature is broken
and removed
[Type] Enhancement
A suggestion for improvement of an existing feature
labels
May 9, 2022
spacedmonkey
approved these changes
May 9, 2022
felixarntz
reviewed
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 One small thing to address here, other than that lgtm.
modules/object-cache/persistent-object-cache-health-check/load.php
Outdated
Show resolved
Hide resolved
3 tasks
felixarntz
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mukeshpanchal27!
felixarntz
changed the title
Correct persistent object cache label
Correct label for persistent object cache Site Health check
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Focus] Object Cache
Issues related to the Object Cache focus area
no milestone
PRs that do not have a defined milestone for release
[Type] Bug
An existing feature is broken
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328
Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.