Update webp_uploads_pre_generate_additional_image_source filter to allow returning file size
#334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o allow returing file size.
eugene-manuilov
added
[Type] Enhancement
eugene-manuilov
requested review from
adamsilverstein,
felixarntz and
mitogh
as code owners
eugene-manuilov
changed the title
mitogh
reviewed
May 15, 2022
mehulkaklotar
requested changes
May 17, 2022
felixarntz
reviewed
May 17, 2022
There was a problem hiding this comment.
@eugene-manuilov Looks pretty much good to go, just one tiny comment.
felixarntz
approved these changes
May 18, 2022
There was a problem hiding this comment.
@eugene-manuilov Looks good!
One remaining non-blocking comment.
jjgrainger
approved these changes
May 19, 2022
felixarntz
approved these changes
May 19, 2022
felixarntz
changed the title
webp_uploads_pre_generate_additional_image_source filter to allow returning file size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #333
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.