Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wp_filesize instead of filesize if available #376

Merged
merged 7 commits into from Jun 15, 2022
Merged

Use wp_filesize instead of filesize if available #376

merged 7 commits into from Jun 15, 2022

Conversation

mehulkaklotar
Copy link
Member

Summary

WordPress 6.0 introduced the wp_filesize() function which should be used in favor of PHP's filesize() going forward.

Fixes #344

Relevant technical choices

This PR changes filesize function to wp_filesize everywhere it was used in the plugin. Code and test cases.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mehulkaklotar mehulkaklotar added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Jun 15, 2022
@mehulkaklotar mehulkaklotar added this to the 1.2.0 milestone Jun 15, 2022
@mehulkaklotar mehulkaklotar self-assigned this Jun 15, 2022
@mehulkaklotar mehulkaklotar added the Needs Review Anything that requires code review label Jun 15, 2022
akshitsethi
akshitsethi reviewed Jun 15, 2022
View reviewed changes
load.php Outdated Show resolved Hide resolved
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Jun 15, 2022
Closed
mitogh
mitogh reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@mitogh mitogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion on the doc block since 6.0 was already released.

Looking good overall.

polyfills.php Outdated Show resolved Hide resolved
felixarntz
felixarntz reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehulkaklotar Thank you, that looks solid. Just one tiny documentation follow-up comment.

@mehulkaklotar @mitogh
Update polyfills.php
bf18dba 
Co-authored-by: Crisoforo Gaspar Hernández <hello@crisoforo.com>
akshitsethi
akshitsethi approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@akshitsethi akshitsethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

felixarntz
felixarntz approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you @mehulkaklotar!

@felixarntz felixarntz merged commit 2f477ea into trunk Jun 15, 2022
@felixarntz felixarntz deleted the add/wp_filesize-fuction branch June 15, 2022 19:32
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitogh mitogh mitogh left review comments

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 left review comments

@akshitsethi akshitsethi akshitsethi approved these changes

@felixarntz felixarntz felixarntz approved these changes

@manuelRod manuelRod Awaiting requested review from manuelRod

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

Assignees

@mehulkaklotar mehulkaklotar

Labels
Infrastructure Issues for the overall performance plugin infrastructure Needs Review Anything that requires code review [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Use wp_filesize instead of filesize if available
5 participants
@mehulkaklotar @akshitsethi @felixarntz @mitogh @mukeshpanchal27