Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove perflab_aea_get_resource_file_size() in favor of wp_filesize() #380

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Remove perflab_aea_get_resource_file_size() in favor of wp_filesize() #380

merged 1 commit into from
Jun 21, 2022

Conversation

mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Jun 16, 2022 •
edited by felixarntz
Loading

Summary

We already have wp_filesize() function in WP and polifile function in Performance so we don't need perflab_aea_get_resource_file_size() function because it returns wp_filesize().

This PR completely remove perflab_aea_get_resource_file_size() function and use wp_filesize() instead of perflab_aea_get_resource_file_size() in code base. It also remove unit test for perflab_aea_get_resource_file_size() function.

Fixes #378

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Site Health no milestone PRs that do not have a defined milestone for release labels Jun 16, 2022
akshitsethi
akshitsethi approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@akshitsethi akshitsethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mehulkaklotar
mehulkaklotar approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@mehulkaklotar mehulkaklotar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

manuelRod
manuelRod approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@manuelRod manuelRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mukeshpanchal27
Copy link
Member Author

mukeshpanchal27 commented Jun 20, 2022 •
edited
Loading

Assign @felixarntz for final review and then it will marge it on the trunk.

@spacedmonkey spacedmonkey merged commit 7302a01 into WordPress:trunk Jun 21, 2022
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label Jun 21, 2022
@felixarntz felixarntz added this to the 1.3.0 milestone Jun 21, 2022
@felixarntz felixarntz changed the title Remove: use of perflab_aea_get_resource_file_size() Remove perflab_aea_get_resource_file_size() in favor of wp_filesize() Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedmonkey spacedmonkey spacedmonkey approved these changes

@akshitsethi akshitsethi akshitsethi approved these changes

@manuelRod manuelRod manuelRod approved these changes

@mehulkaklotar mehulkaklotar mehulkaklotar approved these changes

Assignees

@felixarntz felixarntz

Labels
[Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Remove use of perflab_aea_get_resource_file_size()
6 participants
@mukeshpanchal27 @spacedmonkey @akshitsethi @manuelRod @mehulkaklotar @felixarntz