Optimize computing dominant color and transparency for images by combining the two functions #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or_has_transparency() functions into single function Updated tests and improved the images Introduced two new functions dominant_color_get_dominant_color() and dominant_color_has_transparency() that fetchs the date from image meta
…or_has_transparency() functions into single function Updated tests and improved the images Introduced two new functions dominant_color_get_dominant_color() and dominant_color_has_transparency() that fetchs the date from image meta
pbearne
added
[Focus] Images
…or_has_transparency() functions into single function Updated tests and improved the images Introduced two new functions dominant_color_get_dominant_color() and dominant_color_has_transparency() that fetchs the date from image meta
| $hex = dechex( imagecolorat( $shorted_image, 0, 0 ) ); | ||
|
|
||
| if ( strlen( $hex ) < 6 ) { | ||
| return new WP_Error( 'image_editor_dominant_color_error', __( 'Dominant color detection failed.', 'performance-lab' ) ); | ||
| } | ||
| return $hex; | ||
| return dechex( imagecolorat( $shorted_image, 0, 0 ) ); |
There was a problem hiding this comment.
Can you explain this change a little more.
There was a problem hiding this comment.
we are getting color with the shorten form #fff back from the underlining PHP code
There was a problem hiding this comment.
I think it better to always return a 6 character hex here.
modules/images/dominant-color/class-dominant-color-image-editor-imagick.php
Show resolved
Hide resolved
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
felixarntz
reviewed
Jun 22, 2022
There was a problem hiding this comment.
@pbearne I think the changes related to the issue look good for the most part, but this PR includes a bunch of additional changes which I think are out of scope as they do not relate to the underlying issue.
I think the only changes that are needed here are those in the load.php file (plus related tests). What is the reasoning for modifying the implementation of the image classes here? That seems out of scope.
felixarntz
added
the
[Plugin] Image Placeholders
felixarntz
changed the title
modules/images/dominant-color/class-dominant-color-image-editor-gd.php
Outdated
Show resolved
Hide resolved
…ing_up_image_editor
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
modules/images/dominant-color/class-dominant-color-image-editor-gd.php
Outdated
Show resolved
Hide resolved
|
|
||
| if ( strlen( $hex ) < 6 ) { | ||
| $rgb = imagecolorat( $shorted_image, 0, 0 ); | ||
| $r = ( $rgb >> 16 ) & 0xFF; |
There was a problem hiding this comment.
spacedmonkey
approved these changes
Jun 28, 2022
felixarntz
reviewed
Jun 28, 2022
There was a problem hiding this comment.
@pbearne Pretty much LGTM now. The remaining comments are minor, would be great if you could address them.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
felixarntz
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or_has_transparency() functions into single function
Updated tests and improved the images
Introduced two new functions dominant_color_get_dominant_color() and dominant_color_has_transparency() that fetchs the date from image meta
Summary
Fixes #
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.