Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP notice and bug in logic for when webp_uploads_prefer_smaller_image_file filter is set to true #397

Merged
merged 1 commit into from Jun 28, 2022
Merged

Fix PHP notice and bug in logic for when webp_uploads_prefer_smaller_image_file filter is set to true #397

merged 1 commit into from Jun 28, 2022

Conversation

mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Jun 28, 2022 •
edited by felixarntz

Summary

When I work on #372 bug I found this bug that needs to fix.

Fixes #396

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken [Focus] Images Issues related to the Images focus area [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) no milestone PRs that do not have a defined milestone for release labels Jun 28, 2022
@bethanylang bethanylang added this to Backlog in [Focus] Images via automation Jun 28, 2022
@bethanylang bethanylang moved this from Backlog to Review in [Focus] Images Jun 28, 2022
felixarntz
felixarntz approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@felixarntz felixarntz changed the title When webp_uploads_prefer_smaller_image_file is set to true, an undefine error occurs Fix PHP notice and bug in logic for when webp_uploads_prefer_smaller_image_file filter is set to true Jun 28, 2022
@felixarntz felixarntz added this to the 1.3.0 milestone Jun 28, 2022
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label Jun 28, 2022
@felixarntz felixarntz merged commit 5a7b891 into trunk Jun 28, 2022
[Focus] Images automation moved this from Review to Done Jun 28, 2022
@felixarntz felixarntz deleted the fix/396-undefine-error branch June 28, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshitsethi akshitsethi akshitsethi approved these changes

@felixarntz felixarntz felixarntz approved these changes

@jjgrainger jjgrainger Awaiting requested review from jjgrainger

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@mitogh mitogh Awaiting requested review from mitogh

Assignees
No one assigned
Labels
[Focus] Images Issues related to the Images focus area [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken
Projects
[Focus] Images
Done
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

When webp_uploads_prefer_smaller_image_file is set to true, an undefine error occurs
3 participants
@mukeshpanchal27 @akshitsethi @felixarntz