Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid including .husky directory in plugin ZIP #421

Merged
merged 1 commit into from Jul 7, 2022
Merged

Avoid including .husky directory in plugin ZIP #421

merged 1 commit into from Jul 7, 2022

Conversation

akshitsethi
Copy link
Contributor

@akshitsethi akshitsethi commented Jul 7, 2022 •
edited

Summary

Fixes #386

Relevant technical choices

This PR adds the .husky folder to the .gitattributes file so that it's not copied over during build time.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@akshitsethi akshitsethi added Infrastructure Issues for the overall performance plugin infrastructure [Type] Bug An existing feature is broken labels Jul 7, 2022
@akshitsethi akshitsethi added this to the 1.3.0 milestone Jul 7, 2022
@akshitsethi akshitsethi added the Needs Review Anything that requires code review label Jul 7, 2022
jjgrainger
jjgrainger approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@jjgrainger jjgrainger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshitsethi Looks good, thanks for picking this up

felixarntz
felixarntz approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akshitsethi!

@felixarntz felixarntz merged commit 5ba6ea6 into trunk Jul 7, 2022
@felixarntz felixarntz deleted the fix/386-ignore-husky-built branch July 7, 2022 16:32
@felixarntz felixarntz changed the title Ignore .husky folder Avoid including .husky directory in plugin ZIP Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjgrainger jjgrainger jjgrainger approved these changes

@felixarntz felixarntz felixarntz approved these changes

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure Needs Review Anything that requires code review [Type] Bug An existing feature is broken
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Ignore husky directory on built plugin
3 participants
@akshitsethi @jjgrainger @felixarntz