Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change module slug/directory from dominant-color to dominant-color-images #708

Merged
merged 5 commits into from
Apr 10, 2023

Conversation

felixarntz
Copy link
Member

@felixarntz felixarntz commented Apr 7, 2023

Summary

Follow up to #705.
Related to #640.

Relevant technical choices

  • This PR renames the module directory (which is also the module slug) and updates references accordingly.
  • It includes the old slug under legacy modules so that the data for sites that have the module active is correctly migrated.
  • The PR also changes the module description of Dominant Color Images based on feedback from Configure Dominant Color and Fetchpriority modules for their standalone plugins #704 (review).
  • Generated files and readme.txt are not updated as part of this PR, as those will be updated automatically as part of the release process, except for default-enabled-modules.php, which is used by unit tests and needed to be updated so that they still work correctly.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Documentation Documentation to be added or enhanced [Focus] Images [Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) labels Apr 7, 2023
@felixarntz felixarntz added this to the 2.2.0 milestone Apr 7, 2023
@felixarntz
Copy link
Member Author

cc @mukeshpanchal27 @10upsimon Let's aim to get this merged for the 2.2.0 release as well so that it goes out together with #705. This means we should do some extra testing in this release that, when using an older plugin version and we have the module active it remains active after the update to this release.

I'll be OOO next week, but please feel free to take over this PR, should it require any updates I don't see today.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixarntz, The changes look good to me. In 68fa2df, I have updated two @group annotation instances.

@mukeshpanchal27 mukeshpanchal27 merged commit f7a4620 into trunk Apr 10, 2023
@mukeshpanchal27 mukeshpanchal27 deleted the rename/dominant-color-slug branch April 10, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) [Type] Documentation Documentation to be added or enhanced
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants