Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SQLite module #764

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Remove SQLite module #764

merged 5 commits into from
Jul 6, 2023

Conversation

felixarntz
Copy link
Member

Summary

Fixes #738

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Database labels Jun 22, 2023
@felixarntz felixarntz added this to the 2.5.0 milestone Jun 22, 2023
@felixarntz felixarntz changed the title Remove/sqlite module Remove SQLite module Jun 22, 2023
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixarntz for the PR! It looks solid.

Can we also consider removing certain functions and text associated with SQLite?

  • Activate and deactivated module code that introduce through module integration that we did not use for any other module.
    • perflab_run_module_activation_deactivation()
    • perflab_activate_module()
    • perflab_deactivate_module()
    • 'update_option_' . PERFLAB_MODULES_SETTING action
    • 'add_option_' . PERFLAB_MODULES_SETTING action
  • Remove SQLite Integration from readme.txt

@felixarntz
Copy link
Member Author

@mukeshpanchal27 While the functions you reference were added as part of the SQLite PR, they are generally applicable and part of the infrastructure itself, as they could be useful for any module in the future. So I think we should keep them.

Regarding the readme.txt update, this will be taken care of automatically as part of the release process, via npm run readme.

@mukeshpanchal27 mukeshpanchal27 merged commit eb94df5 into trunk Jul 6, 2023
6 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the remove/sqlite-module branch July 6, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SQLite module from Performance Lab plugin
3 participants