New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum required PHP version to 7.0 and minimum required WP version to 6.3 #851
Conversation
@felixarntz, should we include the update of the standalone plugin version as part of this PR, or would it be better to handle it in a separate PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mukeshpanchal27, LGTM!
Happy to merge this despite the one outstanding point mentioned by @swissspidy. Let's open a separate PR for that, should be a quick one.
Just saw this comment. How about we merge this PR as is, and then open another PR that does the following:
See the new #853. Note that Dominant Color Images doesn't need any version bump because it's not released yet anyway. cc @swissspidy |
Composer install is not failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Pre-approving, pending the fix for a failing composer issue
Summary
Fixes #606
Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.