Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum required PHP version to 7.0 and minimum required WP version to 6.3 #851

Merged
merged 8 commits into from Oct 11, 2023

Conversation

mukeshpanchal27
Copy link
Member

Summary

Fixes #606

  • Bump main plugin minimum required WP version to 6.3
  • Bump standalone plugin minimum required WP version to 6.3.
  • Bump main plugin minimum required PHP version to 7.0.
  • Bump standalone plugin minimum required PHP version to 7.0.
  • Update/remove legacy code.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Oct 10, 2023
@mukeshpanchal27 mukeshpanchal27 self-assigned this Oct 10, 2023
@mukeshpanchal27
Copy link
Member Author

@felixarntz, should we include the update of the standalone plugin version as part of this PR, or would it be better to handle it in a separate PR?

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, LGTM!

Happy to merge this despite the one outstanding point mentioned by @swissspidy. Let's open a separate PR for that, should be a quick one.

modules/images/fetchpriority/readme.txt Outdated Show resolved Hide resolved
@felixarntz
Copy link
Member

felixarntz commented Oct 10, 2023

@mukeshpanchal27

@felixarntz, should we include the update of the standalone plugin version as part of this PR, or would it be better to handle it in a separate PR?

Just saw this comment. How about we merge this PR as is, and then open another PR that does the following:

  • remove Fetchpriority module/plugin completely
  • bump patch version of WebP Uploads plugin

See the new #853.

Note that Dominant Color Images doesn't need any version bump because it's not released yet anyway.

cc @swissspidy

@spacedmonkey
Copy link
Member

Composer install is not failing.

Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Pre-approving, pending the fix for a failing composer issue

@swissspidy swissspidy merged commit 916e134 into trunk Oct 11, 2023
8 checks passed
@swissspidy swissspidy deleted the fix/606-bump-minimum-php-wp-7 branch October 11, 2023 08:46
@felixarntz felixarntz added this to the PL Plugin 2.7.0 milestone Oct 12, 2023
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label Oct 12, 2023
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Oct 18, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump minimum required PHP version to 7.0 and minimum required WP version to 6.3
6 participants