Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image Loading Optimization module #875

Conversation

westonruter
Copy link
Member

Summary

Add scaffolding for new Image Loading Module with some key basic functionality, namely the output buffering of template renders and the introduction of a filter for that buffered output.

Fixes #805

Relevant technical choices

When the module is active, the output buffering UI elements for Server Timing are omitted since the Image Loading Optimization module always does output buffering. Similarly, when the module is running, Server Timing will wait to send the header at the end of the new perflab_template_output_buffer filter.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@westonruter westonruter added [Type] Feature A new feature within an existing module [Focus] Images Issues related to the Images focus area labels Oct 25, 2023
@westonruter westonruter added this to the PL Plugin 2.8.0 milestone Oct 25, 2023
@felixarntz
Copy link
Member

felixarntz commented Nov 2, 2023

@westonruter Can you please update this to be against a feature/* branch? I'm not sure we'd want to ship this yet just with this PR, so I think it shouldn't be against trunk until we're comfortable with the version we have.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter This looks good, just one point of feedback (plus let's change the base branch before merge to a new feature branch).

@westonruter westonruter changed the base branch from trunk to feature/image-loading-optimization November 2, 2023 20:42
@westonruter
Copy link
Member Author

plus let's change the base branch before merge to a new feature branch

@felixarntz I just now pushed up a new feature/image-loading-optimization branch off of trunk and changed the base branch of this PR to target it.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @westonruter!

@felixarntz felixarntz merged commit 795a92f into feature/image-loading-optimization Nov 2, 2023
7 checks passed
@felixarntz felixarntz deleted the add/image-loading-optimization-module branch November 2, 2023 20:55
@felixarntz felixarntz added the no milestone PRs that do not have a defined milestone for release label Nov 17, 2023
@felixarntz felixarntz removed this from the PL Plugin 2.8.0 milestone Nov 17, 2023
@felixarntz
Copy link
Member

Just noted that this PR and #878 are annotated with the PL 2.8.0 release, but it's not actually milestoned for a release yet since we are working in the feature branch towards a working version before moving ahead with merging into trunk. Let's use no milestone on those PRs against the feature branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Images Issues related to the Images focus area no milestone PRs that do not have a defined milestone for release [Plugin] Optimization Detective Issues for the Optimization Detective plugin [Type] Feature A new feature within an existing module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module Proposal: Alternative LCP Optimization (via Output Buffering)
3 participants