New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow module can-load.php
callbacks to return a WP_Error
with more information
#891
Conversation
Co-authored-by: Pascal Birchler <pascalb@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mukeshpanchal27, this looks great. Only a few minor points of feedback on wording and adding a @since
annotation for the technically (low-level) breaking change on the function return value.
tests/testdata/demo-modules/check-error/demo-module-4/can-load.php
Outdated
Show resolved
Hide resolved
can-load.php
callbacks to return a WP_Error
with more information
Milestoning this and #290 for 2.8.0 - not critical, but both of them look very good and we can probably include them in that release. Potentially we can even merge them tomorrow already. |
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Thanks for the feedback. The PR is ready for final review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates @mukeshpanchal27, LGTM!
Summary
Followup work discussed here: #885 (comment)
This PR updates can load infrastructure so that it will support the custom message.
Relevant technical choices
Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.