Update CODEOWNERS to use the new module naming convention #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinyAhin
added
Infrastructure
felixarntz
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
@JustinyAhin Looks good, just one tiny suggestion to "technically" complete this.
|
One last thing @felixarntz. Should I add you as owner for |
|
@JustinyAhin Yeah, probably best if you add both of us since that should IMO be the same as the production code for that, which falls into Infrastructure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23. Follows up on #23 (comment).
This PR update the CODEOWNERS file to reflect the module naming convention. It also updates the code owners based on the latest changes on the focus spreadsheet.