New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce plugins folder for standalone plugins #948
Introduce plugins folder for standalone plugins #948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes.
Co-authored-by: Pascal Birchler <pascalb@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, considering the current requirements on #934. Once you've removed the temporary changes, I think we can merge this.
We may want to keep the issue open though to work in a separate PR on the unit testing setup, to allow for it to test individual plugins as well as Performance Lab, e.g. via distinct test suites (see #934 (comment)).
To test that, we can temporarily move one of the built modules into plugins
, though that part should be reverted before merge since we should not remove the modules until 3.0.0.
Summary
Fixes #934
Relevant technical choices
I have added some TODO for testing purpose once the PR is ready for merge we will remove those TODOs.
Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.