WP-NOW: Use rotatePHPRuntime to avoid memory error #152
Conversation
| }; | ||
|
|
||
| const phpInstances = []; | ||
| const loadRuntime = async () => | ||
| await NodePHP.loadRuntime(options.phpVersion); |
There was a problem hiding this comment.
Property 'loadRuntime' does not exist on type 'typeof NodePHP'.
This GitHub message looks suspicious, otherwise the PR seems to look good.
There was a problem hiding this comment.
I think the GitHub message was because we weren't using the latest version of Playground dependencies. Now it's gone.
|
@brandonpayton this could be interesting for you, and it would also make |
@adamziel, that sounds good! I can take a look. |
|
@adamziel , @bgrgicak , Now that we updated and adapted the Playground dependencies to the latest version, I could finish this PR. Would you mind reviewing it? cc: @brandonpayton |
packages/wp-now/src/wp-now.ts
Outdated
| await rotatePHPRuntime({ | ||
| php, | ||
| recreateRuntime: loadRuntime, | ||
| maxRequests: 400, |
There was a problem hiding this comment.
Maybe let's try 100? Also, it would be nice to detect out of memory errors and auto-rotate – not that it's a blocker here.
| maxRequests: 400, | |
| maxRequests: 100, |
Reverts #152 The php instance rotates correctly, but the new php instance doesn't have any folder mounted. It's a clean php. Reverting for now, and I'll create another PR. After rotating I get this result: `404 File not found`, and I confirmed the document root folder doesn't exist in VFS and therefore the WordPress files. <img width="518" alt="Captura de pantalla 2024-03-22 a las 12 52 35" src="https://github.com/WordPress/playground-tools/assets/779993/7242e364-cbb8-48a7-9e39-a703b49bba26"> cc: @adamziel
|
@adamziel , I reverted this PR. As it seems it was returning a |
What?
It uses the new function
rotatePHPRuntimeto mitigate the memory error.How?
Update the dependencies and use
rotatePHPRuntimefor the main instance.Testing Instructions
nvm use && npm installnpx nx build wp-nownode dist/packages/wp-now/cli.js start