New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Playground dependencies to 0.6.7 #157
Update Playground dependencies to 0.6.7 #157
Conversation
The fix introduced on WordPress/wordpress-playground#1000, seems to be failing. The "transpiled" JS is like:
Where
So it's not really importing the cyrpto library from Node.js |
…date/playground-dependencies-to-introduce-crypto-globally
I confirm after upgrading the dependencies, Now I can run blueprints:
|
@adamziel , this PR is ready for review. I can release wp-now after this one is merged. |
<?php | ||
|
||
// File needs to exist to avoid throwing a 404 error | ||
|
||
header('Location: /wp-admin/'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new wp-login.php
file is necessary to avoid this new exception on the blueprint step:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work @sejas !
@sejas 0.6.5 is out. We should update this branch to the latest version. |
What?
Why?
To remove crypto dependency in node applications
How?
Updating the main
package.json
Testing Instructions
nvm use && npm install
npm run build
node dist/packages/wp-now/cli.js start --blueprint=b.json
where b.json is a blueprint withTypeError: crypto.randomUUID is not a function