Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-NOW: Open browser with blueprint landingPage instead of absoluteUrl #233

Merged
merged 1 commit into from Apr 15, 2024

Conversation

sejas
Copy link
Collaborator

@sejas sejas commented Apr 13, 2024

What?

Open blueprint landingPage when defined instead of absoluteUrl.

Why?

It improves the UX of some use cases, for example https://github.com/adamziel/playground-docs-workflow/tree/trunk/wp-content

How?

It adds a new property to WpNowOptions object

Testing Instructions

  • Run npx nx run wp-now:build
  • Create a blueprint with a landing page:
{
	"landingPage": "/wp-admin/edit.php?post_type=post",
	"features": {
		"networking": true
	},
	"steps": [
		{
			"step": "login",
			"username": "admin",
			"password": "password"
		}
	]
}
  • Run node dist/packages/wp-now/cli.js start --blueprint=b.json
  • Observe the browser opens the landingPage in wp-admin instead of the homepage.
respect-landing-page.mp4

cc: @flexseth

@sejas sejas added the wp-now label Apr 13, 2024
@sejas sejas self-assigned this Apr 13, 2024
@sejas sejas merged commit bca8656 into trunk Apr 15, 2024
2 checks passed
@sejas sejas deleted the update/wp-now-respect-blueprint-landingpage branch April 15, 2024 11:10
@flexseth
Copy link

Thanks for looking at this @sejas - adding it to the list of items to test out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants