Fix PHP 7.2.x Syntax Error Causing Site-wide Fatal Server Error (Trailing Comma in the Parameters of a Function) #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion being called) The plugin claims PHP 7.0+ support, but the trailing comma in the parameters when calling `wp_register_style` is a syntax error for PHP 7.2 (and possibly others) which then causes a site-wide fatal server error. Either need to not try to and/or claim support of PHP 7.2 & older, or make this one fix & be mindful to not have these trailing commas (they're not doing anything anyway & just cause it to potentially break on some hosting environments; unlike the trailing commas in PHP arrays, etc. for whatever reason.)
bgrgicak
approved these changes
May 16, 2024
|
Thanks for the fix @KZeni! |
This can also be tested using the dev server by adding a |
|
Thank you so much for contributing @KZeni! |
|
@bgrgicak would you please release a new version? |
|
Version 0.2.5 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The plugin claims PHP 7.0+ support, but the trailing comma in the parameters when calling
wp_register_styleis a syntax error for PHP 7.2.x (and possibly others) which then causes a site-wide fatal server error when the plugin is enabled.The exact error message is:
Why?
This either needs to not try to and/or claim support of PHP 7.2 & older, or (per this pull request) make this one fix & just be mindful to not have these trailing commas in future updates and/or have the plugin files be checked for this type of thing via CI before releasing a new version (these trailing commas don't do anything anyway & just cause it to potentially break on some hosting environments; unlike the trailing commas in PHP arrays, etc. for whatever reason.)
How?
This simply removes the comma at the end of
wp_register_style's parameters which isn't doing anything other than breaking things for those with PHP 7.2.x.Testing Instructions