Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement try in checks preparation #383

Closed
wants to merge 1 commit into from
Closed

Implement try in checks preparation #383

wants to merge 1 commit into from

Conversation

ernilambar
Copy link
Contributor

No description provided.

@ernilambar ernilambar marked this pull request as draft January 10, 2024 10:09
@ernilambar
Copy link
Contributor Author

Adding try in final public function prepare() in abstract class Abstract_Check_Runner hides that fatal error. But I doubt keeping try there with empty catch block is good approach.

@ernilambar ernilambar mentioned this pull request Jan 10, 2024
Open
@ernilambar
Copy link
Contributor Author

Closing this. We need to research for more robust approach.

@ernilambar ernilambar closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ernilambar