Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fatal error when in checks in --checks and --exclude-checks overlaps #387

Merged
merged 3 commits into from Jan 12, 2024
Merged

Fix: Fatal error when in checks in --checks and --exclude-checks overlaps #387

merged 3 commits into from Jan 12, 2024

Conversation

mukeshpanchal27
Copy link
Member

Closes #359

Checklist:

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review January 11, 2024 08:56
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Jan 11, 2024
Closed
felixarntz
felixarntz requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fix here currently breaks another intentional functionality.

includes/Checker/Abstract_Check_Runner.php Outdated Show resolved Hide resolved
felixarntz
felixarntz approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27!

@felixarntz felixarntz merged commit 0e0f38d into trunk Jan 12, 2024
24 checks passed
@felixarntz felixarntz deleted the fix/checks-exclude-checks-overlaps branch January 12, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@ernilambar ernilambar ernilambar approved these changes

@felixarntz felixarntz felixarntz approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal error when in checks in --checks and --exclude-checks overlaps
4 participants
@mukeshpanchal27 @swissspidy @ernilambar @felixarntz