Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Foundation #43

Merged
merged 6 commits into from Dec 16, 2022
Merged

Plugin Foundation #43

merged 6 commits into from Dec 16, 2022

Conversation

jjgrainger
Copy link
Contributor

@jjgrainger jjgrainger commented Dec 13, 2022 •
edited

Adds initial project files and directories.

  • I've added additional files based on the Performance Lab plugin not listed in the ACs such as SECURITY.md, CODE_OF_CONDUCT.md and LICENSE
  • I've also opted for the wordpress/plugin-check namespace, instead of 10up/plugin-check knowing this repo will be moved across at a later date.

Closes #1

@jjgrainger jjgrainger added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall plugin infrastructure Milestone 1 labels Dec 13, 2022
@jjgrainger jjgrainger requested review from mukeshpanchal27 and removed request for mehulkaklotar December 13, 2022 16:43
@jjgrainger jjgrainger marked this pull request as ready for review December 13, 2022 16:43
@jjgrainger jjgrainger mentioned this pull request Dec 13, 2022
Merged
felixarntz
felixarntz reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjgrainger Almost LGTM, just one tiny thing, and another observation to handle separately.

composer.json Outdated Show resolved Hide resolved
readme.txt Show resolved Hide resolved
@jjgrainger jjgrainger mentioned this pull request Dec 14, 2022
Closed
mukeshpanchal27
mukeshpanchal27 reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjgrainger Left some nit-pick feedbacks

README.md Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
readme.txt Outdated Show resolved Hide resolved
plugin-check.php Outdated Show resolved Hide resolved
mukeshpanchal27
mukeshpanchal27 reviewed Dec 16, 2022
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjgrainger Left some nit-pick feedback.

composer.json Outdated Show resolved Hide resolved
plugin-check.php Show resolved Hide resolved
@jjgrainger
Copy link
Contributor Author

Thanks @jjgrainger Left some nit-pick feedback.

@mukeshpanchal27 the AC actually uses tests. There is a type of test in the "Directory structure of the plugin" section of the issue. I will update this but believe that tests is correct based on what I've seen in other repo's including the Performance Lab repo.

@mukeshpanchal27
Copy link
Member

Thanks @jjgrainger for clarification.

mukeshpanchal27
mukeshpanchal27 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work, @jjgrainger

felixarntz
felixarntz approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjgrainger, LGTM!

@felixarntz felixarntz merged commit 6986ebc into trunk Dec 16, 2022
@felixarntz felixarntz deleted the feature/plugin-foundation branch December 16, 2022 19:26
bordoni pushed a commit that referenced this pull request Sep 13, 2023
@EvanHerman
Add application files check (#43)
b081cf7 
* Add application files check

* Add .phar extension and alphabetize the array

* add .DS_Store to exclusion list

* Updates

* Abstract throw_error
bordoni added a commit that referenced this pull request Sep 13, 2023
@bordoni
Add docblocks and changelog for #43
a1f8d12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

Assignees
No one assigned
Labels
Infrastructure Issues for the overall plugin infrastructure Milestone 1 [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin Foundation
3 participants
@jjgrainger @mukeshpanchal27 @felixarntz