Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use normalized path #449

Merged
merged 2 commits into from Apr 4, 2024
Merged

Use normalized path #449

merged 2 commits into from Apr 4, 2024

Conversation

ernilambar
Copy link
Contributor

Fixes #434

  • Use normalized path when fetching list files and folders

@ernilambar ernilambar force-pushed the fix/normalize branch 2 times, most recently from f9d2710 to 89b9739 Compare April 1, 2024 07:08
@ernilambar ernilambar marked this pull request as ready for review April 1, 2024 07:12
@ernilambar
Copy link
Contributor Author

@felixarntz May be using this approach will avoid fixing Windows issues randomly.

felixarntz
felixarntz reviewed Apr 1, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ernilambar for the updates, this looks solid.

readme.txt Outdated Show resolved Hide resolved
includes/Checker/Checks/Abstract_File_Check.php Show resolved Hide resolved
@swissspidy swissspidy merged commit 3d6af26 into WordPress:trunk Apr 4, 2024
24 checks passed
@swissspidy swissspidy added this to the 1.1.0 milestone Apr 4, 2024
@swissspidy
Copy link
Member

This seems to theow some errors, the function might not be available in some contexts. See WordPress/plugin-check-action#68

swissspidy added a commit that referenced this pull request Apr 8, 2024
@swissspidy
Fix fatal error introduced in #449
79efce7
@swissspidy swissspidy mentioned this pull request Apr 8, 2024
Merged
mukeshpanchal27 added a commit that referenced this pull request Apr 9, 2024
@mukeshpanchal27
Merge pull request #453 from WordPress/fix/cli-fatal
6721eb4 
Fix fatal error introduced in #449
@ernilambar ernilambar deleted the fix/normalize branch April 9, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@felixarntz felixarntz Awaiting requested review from felixarntz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Windows: Plugin check reports that readme.txt file is missing. Edit Link fails for other files.
4 participants
@ernilambar @swissspidy @felixarntz @mukeshpanchal27