Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency can cause email spam when repeated jobs are cancelled. #50

Open
costdev opened this issue Feb 2, 2024 · 0 comments
Open
Assignees
Labels
[Type] Bug Report Something isn't working

Comments

@costdev
Copy link
Contributor

costdev commented Feb 2, 2024

Description

When Props-Bot is already running, a run triggered by a comment will be cancelled, which will send out email/push notifications (depending on settings) to the commenter. This can get quite noisy when involved discussions across various threads in a PR, for example.

The Props-bot action is likely quick enough that we don't need to worry about concurrency, but I think it would be good to discuss this further to avoid a bunch of folks setting up email filter rules, or worse, learning to ignore notifications due to the number they receive.

Version

v1

Workflow file

No response

Link

No response

@costdev costdev added the [Type] Bug Report Something isn't working label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants