Update class-wp-sqlite-translator.php

[lucazdj]

Fixing message error in diagnostics page

[eliot-akira]

I believe this pull request is meant to solve #37, where a fatal error is thrown due to this line.

-$table_name = property_exists( $table, 'Name' ) ? $table->Name : $table->table_name; // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase
+$table_name = is_object( $table ) && property_exists( $table, 'Name' ) ? $table->Name : $table->table_name; // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase

However, adding the check is_object( $table ) is not enough to solve the issue completely because the error message is:

Uncaught TypeError: property_exists():
Argument #1 ($object_or_class) must be of type object|string, array given

It means the variable $table is an array for some reason. In the changed line, if the variable is not an object, the condition tries to access $table->table_name which will throw another type error.

I think the real solution to find out why $table is not an object as expected, somewhere earlier in the error stack trace posted in that issue #37 (comment).

Otherwise, as a temporary solution, the array_filter callback can return false for this exception at the top of the function.

if ( ! is_object( $table ) ) return false;

[aristath]

Hmmm I don't think this would actually fix the issue...
if it's not an object, it will try to get $table->table_name which will again error.

Perhaps we should just add an additional condition above this line?
Something like this:

if ( ! is_object( $table ) ) {
	return false;
}

[aristath]

Closing this one as a fix has already been committed for it in 0753b7c a couple of weeks ago 👍