Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screenshot dimensions #387

Closed
kafleg opened this issue Aug 16, 2021 · 3 comments
Closed

Screenshot dimensions #387

kafleg opened this issue Aug 16, 2021 · 3 comments

Comments

@kafleg
Copy link
Member

kafleg commented Aug 16, 2021

Theme having invalid screenshot size doesn't restrict uploads or not showing any information in Theme Check Results: section in trac. Ticket, https://themes.trac.wordpress.org/ticket/104212

REQUIRED Screenshot dimensions are wrong! The ratio of width to height should be 4:3.

This is the message showing using the theme check plugin locally.

Also, there is information on the RECOMMENDED section,
RECOMMENDED Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
@TeBenachi
Copy link
Contributor

When a screenshot is larger than 1200x900, the theme check prompts two alerts.
Consolidating into one alert may be less confusing to the authors.

Screen Shot 2021-08-18 at 4 58 46 AM

@carolinan
Copy link
Collaborator

Ratio and size are two different problems, not one.

@kafleg
Copy link
Member Author

kafleg commented Nov 30, 2021

Related to this, #401

I am closing this issue.

@kafleg kafleg closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carolinan @kafleg @TeBenachi