Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect @import and also CDN URL #90

Closed
ernilambar opened this issue Sep 17, 2015 · 1 comment
Closed

Detect @import and also CDN URL #90

ernilambar opened this issue Sep 17, 2015 · 1 comment

Comments

@ernilambar
Copy link
Member

While I was reviewing a theme I found following in style.css.

Detect CDN import in style.css.

@import url(//maxcdn.bootstrapcdn.com/font-awesome/4.3.0/css/font-awesome.min.css);

This should be blocker I believe.

Also, may be it would be good to detect @import and recommend theme author to use proper hooks and functions to load styles and fonts.

@import url(http://fonts.googleapis.com/css?family=Arimo:400,400italic,700,700italic);

@Otto42
Copy link
Member

Otto42 commented Sep 21, 2015

The cdn.php check only checks the php code, not the CSS files. It should check both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants