Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the current theme path handling out of tc_filename() and optimize it to query once per theme #397

Merged
merged 1 commit into from Sep 13, 2021

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Sep 7, 2021

As a follow up to #370, the change causes it to query all the files for a theme on every call to tc_filename() which on some themes can be a significant number.

This splits the function into two, and uses a static cache to only query the files once per theme tested.

@carolinan
Copy link
Collaborator

I have tested with different types of themes and with #389 and I don't see any issues, timeouts or other.

@carolinan carolinan merged commit 104ab80 into master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants