Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme phoenix #155

Merged
merged 3 commits into from
Feb 15, 2021
Merged

Conversation

imranhsayed
Copy link
Contributor

@imranhsayed imranhsayed commented Dec 27, 2020

Adds Theme Phoenix - an experimental block based theme.

Features and Description

  1. It uses the Navigation block in the header.
  2. Front page block template contains
  • Hero section
  • Latest posts using Query Block
  • Sidebar containing Gallery, Social Links, Categories and Search Blocks.
  1. Single page, Single post and 404 block templates.

All the sections are editable from WordPress Dashboard > Site Editor

Live Demo Site

screencapture-phoenix-codeytek-2020-12-27-13_56_01-1

image

@kjellr kjellr added block-based theme A theme using HTML templates needs testing labels Jan 4, 2021
@pbking
Copy link
Collaborator

pbking commented Feb 5, 2021

It's interesting to see a FSE theme that is NOT using the (experimental-)theme.json. It absolutely works in wp-admin and the views, however without it the Full Site Editor itself doesn't load. I just copied the simple theme.json from emptytheme and that was enough to make things work, however you may want to adjust things further before bringing this in.

@imranhsayed
Copy link
Contributor Author

Thank you for your feedback @pbking .
I have implemented the feedback and added the (experimental)-theme.json with settings as per the theme requirements.
The global styles work great with Gutenberg v9.8.4 . However the v9.9 has some issues with the global styles application.

@pbking
Copy link
Collaborator

pbking commented Feb 8, 2021

The global styles work great with Gutenberg v9.8.4 . However the v9.9 has some issues with the global styles application.

There were breaking changes regarding the JSON structure. You can read up more about that here: https://make.wordpress.org/themes/2021/02/04/gutenberg-9-9-new-json-structure-for-theme-json-files/

I should have mentioned that any only just realized that the version in empty themes is the the old structure.

@imranhsayed
Copy link
Contributor Author

Thank you for the update @pbking . I have made the necessary changes as suggested.

@imranhsayed
Copy link
Contributor Author

Hi @pbking,
Please let me know if there are any other changes required 😊

@pbking pbking merged commit 0a51f71 into WordPress:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-based theme A theme using HTML templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants