Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Support for WP version #431

Closed
LittleBigThing opened this issue Oct 31, 2018 · 4 comments
Closed

Support for WP version #431

LittleBigThing opened this issue Oct 31, 2018 · 4 comments
Labels
Milestone

Comments

@LittleBigThing
Copy link

I did some testing with the theme in previous versions of WordPress.

I started with 4.6.12.

  • the theme was not compatible, at least due to the use of the function get_theme_file_uri(). This function was indeed introduced in 4.7.
  • in addition to this, I think that the Customizer hue control used for selecting the custom primary color isn't compatible with lower versions of WordPress either. The hue control was introduced for the default theme Twenty Seventeen.

I checked with version 4.7.11 as well as 4.8.6 and these versions seemed to work fine.

I suggest to add a version check in the functions.php file, as it was done for Twenty Seventeen. I suggest that we set 4.7+.
To be able to take advantage of the privacy policy functions, we would need 4.9.6+. However, since we check whether the required function exists, we don't break anything between 4.7 and 4.9.6.

Another consideration could be whether 5.0 should be the first supported version since the theme is meant to showcase Gutenberg. Although guess that users on earlier versions could try Gutenberg as well using the plugin.

@joyously
Copy link

This was already mentioned in #207 and in the comments for #72.
Only the readme was updated.

@LittleBigThing
Copy link
Author

Ok, missed the outcome of that discussion, sorry.
But I do think that #432 would be a gentle solution to avoid ugly errors being generated < 4.7.

@joyously
Copy link

I agree that it is probably needed. I was just providing references.

@kjellr kjellr added the task label Oct 31, 2018
@kjellr kjellr added this to the RC1 milestone Oct 31, 2018
@kjellr
Copy link
Collaborator

kjellr commented Nov 6, 2018

Closing since #432 was merged. 👍

@kjellr kjellr closed this as completed Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants