You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
I did some testing with the theme in previous versions of WordPress.
I started with 4.6.12.
the theme was not compatible, at least due to the use of the function get_theme_file_uri(). This function was indeed introduced in 4.7.
in addition to this, I think that the Customizer hue control used for selecting the custom primary color isn't compatible with lower versions of WordPress either. The hue control was introduced for the default theme Twenty Seventeen.
I checked with version 4.7.11 as well as 4.8.6 and these versions seemed to work fine.
I suggest to add a version check in the functions.php file, as it was done for Twenty Seventeen. I suggest that we set 4.7+.
To be able to take advantage of the privacy policy functions, we would need 4.9.6+. However, since we check whether the required function exists, we don't break anything between 4.7 and 4.9.6.
Another consideration could be whether 5.0 should be the first supported version since the theme is meant to showcase Gutenberg. Although guess that users on earlier versions could try Gutenberg as well using the plugin.
The text was updated successfully, but these errors were encountered:
I did some testing with the theme in previous versions of WordPress.
I started with 4.6.12.
get_theme_file_uri()
. This function was indeed introduced in 4.7.I checked with version 4.7.11 as well as 4.8.6 and these versions seemed to work fine.
I suggest to add a version check in the
functions.php
file, as it was done for Twenty Seventeen. I suggest that we set 4.7+.To be able to take advantage of the privacy policy functions, we would need 4.9.6+. However, since we check whether the required function exists, we don't break anything between 4.7 and 4.9.6.
Another consideration could be whether 5.0 should be the first supported version since the theme is meant to showcase Gutenberg. Although guess that users on earlier versions could try Gutenberg as well using the plugin.
The text was updated successfully, but these errors were encountered: