Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

WP version check #432

Merged
merged 5 commits into from
Nov 5, 2018
Merged

Conversation

LittleBigThing
Copy link

Related to #431

We might need to add a check for compatibility with previous versions of WordPress to avoid errors on versions before 4.7.

Csaba and others added 3 commits October 30, 2018 13:13
checking the WP version if it is needed for the hue color control
add back compat file from Twenty Seventeen
trying to fix failed checks Travis
@kjellr kjellr requested a review from allancole November 5, 2018 14:54
Copy link
Collaborator

@allancole allancole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. I tried it with WP version 4.5.15 and it prevents the theme from being activated and encourages the user to upgrade to the lowest supported version.

Here’s the message I received after attempting to activate Twenty Nineteen:
image

@allancole allancole merged commit 42ad6a0 into WordPress:master Nov 5, 2018
@LittleBigThing LittleBigThing deleted the wp-version-check branch November 6, 2018 05:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants