This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
Adds async/defer capability to JavaScript loading #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…skip-link-focus-fix to improve performance.
westonruter
reviewed
Oct 16, 2018
functions.php
Outdated
| @@ -117,7 +117,8 @@ function twentynineteen_content_width() { | |||
| function twentynineteen_scripts() { | |||
| wp_enqueue_style( 'twentynineteen-style', get_stylesheet_uri() ); | |||
|
|
|||
| wp_enqueue_script( 'twentynineteen-skip-link-focus-fix', get_template_directory_uri() . '/js/skip-link-focus-fix.js', array(), '20151215', true ); | |||
| wp_enqueue_script( 'twentynineteen-skip-link-focus-fix', get_template_directory_uri() . '/js/skip-link-focus-fix.js', array(), '20151215', false ); | |||
| wp_script_add_data( 'twentynineteen-skip-link-focus-fix', 'defer', true ); | |||
There was a problem hiding this comment.
This will be unnecessary (for skip-link-focus-fix) with this change applied: Automattic/_s#1323
See also note on wprig/wprig#139 for why defer is not ideal for skip-link-focus-fix either.
There was a problem hiding this comment.
Right, I totally forgot. The functionality still stands though (I expect some JS will be added to this theme at some point.)
There was a problem hiding this comment.
PR to apply the fix to the blocking script: #47
|
I've updated the PR to not defer |
|
Closed in favor of #646 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async/defercapability to JavaScript loading.twentynineteen-skip-link-focus-fixto improve performance.async/deferis new best practice for JS loading and should be used for all enqueued JS on the front end in place of loading in footer. This feature allows control of JS loading by adding the following code to any enqueued script:Corresponds with https://core.trac.wordpress.org/ticket/12009 and gracefully falls back if/when this feature is added to core.
Code by @westonruter, originally contributed to WP Rig