Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Try: Use non-breaking space override globally #585

Merged
merged 1 commit into from Nov 14, 2018

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Nov 13, 2018

A followup to #463.

This PR takes the   font override from our editor styles and applies it to the front end as well. It aligns the width of Hoefler Text non-breaking spaces in Chrome with their width in other browsers, and if all goes well, it should have no effect on the front end except when viewing a site in Chrome on a Mac.

In that case, you'll notice that &nbsp characters are shorter. For instance, nested submenu items will appear differently:

Before
screen shot 2018-11-13 at 3 54 56 pm

After
screen shot 2018-11-13 at 3 55 09 pm

@kjellr kjellr added the enhancement New feature or request label Nov 13, 2018
@kjellr kjellr self-assigned this Nov 13, 2018
Copy link
Collaborator

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. Ship it.

Even if the fix can be further improved or even deprecated at some point, this consistency will be a good start.

@kjellr kjellr merged commit 8f48521 into master Nov 14, 2018
@kjellr
Copy link
Collaborator Author

kjellr commented Nov 14, 2018

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants