Skip to content
This repository has been archived by the owner on Dec 1, 2019. It is now read-only.

Can we please add a sidebar? #13

Closed
joyously opened this issue Sep 6, 2019 · 7 comments
Closed

Can we please add a sidebar? #13

joyously opened this issue Sep 6, 2019 · 7 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@joyously
Copy link

joyously commented Sep 6, 2019

One of the worst parts about Twenty Nineteen is that there is no sidebar.
This is especially bad for users with custom widgets that have to switch to the default theme to troubleshoot their site. Because of the way that core reassigns widgets, those widgets end up inactive when the theme is switched back.

And it's time for the default theme to show how to use a sidebar with full width blocks.

@carolinan carolinan added the enhancement New feature or request label Sep 7, 2019
@carolinan
Copy link
Contributor

I don't think the theme should have a sidebar, but the id's of the widget areas could be renamed
to sidebar-1 and sidebar-2 that are more commonly used, to avoid (but not guarantee) that widgets end up inactive.

@joyously
Copy link
Author

joyously commented Sep 7, 2019

I prefer pages with sidebars. They feel dead-end to me without one.
And I don't think it makes sense to name them sidebar if they are in the footer. There are matches for that also, in the core code.

@ZebulanStanphill
Copy link
Member

Yeah, a page template with a sidebar is good for things like showing latest posts, post archive links, and tags while reading a blog post. It shouldn't be the default, in my opinion, but it should definitely be an option to set a template with a sidebar as the default for blog posts (and/or pages if desired).

@joyously
Copy link
Author

joyously commented Sep 9, 2019

I just switched a test site from Twenty Nineteen to Twenty Twenty, and the footer widgets did not even carry over to the footer. What's up with that? Is it the naming?

carolinan added a commit that referenced this issue Sep 15, 2019
@pattonwebz
Copy link
Member

@joyously You are probably right about it being a naming thing. Here we have footer-one and footer-two and in Twenty Nineteen there is only 1 sidebar with the name sidebar-1. I would have though that this would carry over anyway since it's a single sidebar that could be placed in any one of the two in this theme. Curious why it did not do that though 🤔

@joyously
Copy link
Author

Read the core code. "footer-one" matches "footer", not "sidebar".

@ianbelanger79 ianbelanger79 added wontfix This will not be worked on and removed needs decision labels Sep 18, 2019
@ianbelanger79
Copy link
Contributor

At this point @andersnoren and I do not feel that we have the time to implement a sidebar. Closing the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants