Skip to content
This repository has been archived by the owner on Dec 1, 2019. It is now read-only.

Remove button style "Squared" from button block #573

Closed
nielslange opened this issue Sep 27, 2019 · 2 comments · Fixed by #577
Closed

Remove button style "Squared" from button block #573

nielslange opened this issue Sep 27, 2019 · 2 comments · Fixed by #577
Assignees
@nielslange
Labels
block Editor blocks or blocks on the front enhancement New feature or request Has PR Has pull request needs decision

Comments

@nielslange
Copy link
Collaborator

The button block comes with the following three styles:

  • Default → Rounded button
  • Outline → Rounded, outlined button
  • Squared → Squared button

With Twenty Twenty we show only squared buttons. Therefore, the Default and the Squared button styles look identical, which might be confusing for some users. To avoid confusion I suggest removing the Squared button style.
@nielslange nielslange added the enhancement New feature or request label Sep 27, 2019
@nielslange nielslange self-assigned this Sep 27, 2019
nielslange added a commit to nielslange/twentytwenty that referenced this issue Sep 27, 2019
@nielslange
UPDATE WordPress#573: Remove button style "Squared" from button block
14f519f
nielslange added a commit to nielslange/twentytwenty that referenced this issue Sep 27, 2019
@nielslange
UPDATE WordPress#573: Remove button style "Squared" from button block
8e6d0f0
@nielslange nielslange mentioned this issue Sep 27, 2019
Merged
@nielslange nielslange added block Editor blocks or blocks on the front Has PR Has pull request labels Sep 27, 2019
nielslange added a commit to nielslange/twentytwenty that referenced this issue Sep 27, 2019
@nielslange
UPDATE WordPress#573: Fix Travis CI issue
1f9cfac
nielslange added a commit to nielslange/twentytwenty that referenced this issue Sep 27, 2019
@nielslange
Merge branch 'master' into update/WordPress#573
c259bdd
@joyously
Copy link

Maybe someone could convince the editor folks that it makes better sense to have the default be Square, and it doesn't need a separate class?

@nielslange
Copy link
Collaborator Author

You could suggest it in https://github.com/WordPress/gutenberg/issues. As for now, don't you think we should remove the Squared button style to avoid confusion?

andersnoren added a commit to nielslange/twentytwenty that referenced this issue Sep 28, 2019
@andersnoren
Merge branch 'master' into update/WordPress#573
a898072
andersnoren pushed a commit that referenced this issue Sep 28, 2019
@nielslange @andersnoren
UPDATE #573: Remove button style "Squared" from button block (#577)
f3a679e 
* UPDATE #573: Remove button style "Squared" from button block

* UPDATE #573: Remove button style "Squared" from button block

* UPDATE #573: Fix Travis CI issue

* UPDATE #537: Replace /* eslint-disable no-undef */ with /* global wp */
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nielslange nielslange

Labels
block Editor blocks or blocks on the front enhancement New feature or request Has PR Has pull request needs decision
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UPDATE #573: Remove button style "Squared" from button block nielslange/twentytwenty
3 participants
@nielslange @joyously @ianbelanger79