Fixed - Two <h1> on static frontpage

[acosmin]

Fix for #490

[mukeshpanchal27]

@acosmin Above fix remove h1 from Posts page.

[acosmin]

@mukeshpanchal27 it looks like that, I'll look into it... the same issue can be found in twentynineteen

[acosmin]

@mukeshpanchal27 please go ahead and try it :) I think I got it right now 😄 I think a patch for twentynineteen is also needed

[mukeshpanchal27]

@acosmin latest patch working fine for me.

@nielslange @ntwb can you please review this.

[acosmin]

I hope this one works :)

[nielslange]

try nr.2

@acosmin As many folks contributing to this repo it would be better to use speaking commit messages such as Enhance title conditions, Adjust <h1> conditions or something along these lines instead of try nr.2, which could be pretty much everything. 😁

Personally, I also add the issue ID to the commit message (if I do not apply changes directly to the origin) to highlight which issue is affected by the commit: https://github.com/WordPress/twentytwenty/commits?author=nielslange

[acosmin]

Agreed, I'll do that from now on 😄

Also, I think this last one did fix it 🤣

[nielslange]

@acosmin I'm not sure if is_page_template() can replace is_archive() and is_author() though. Wanna give try nr.3 a try? 😂

[acosmin]

@nielslange not really, I think this is the final one 😆 try it out, it works for me on archive and author pages... and the rest of them

[nielslange]

@acosmin Indeed, the latest commit fixed it. LGTM! 🙌

[acosmin]

twentynineteen also has some of these problems

[nielslange]

twentynineteen also has some of these problems

You know how to fix it now, don't you? 😛

[acosmin]

I do but I hate trac :)

[nielslange]

I know what you mean. I'm not a big fan of Trac either, but you get used to it. 😉

[pattonwebz]

I made a ticket XD https://core.trac.wordpress.org/ticket/48126

[ianbelanger79]

@acosmin This does not seem to fix the issue when using a static homepage. I still see 2 <h1>'s

[nielslange]

@acosmin This does not seem to fix the issue when using a static homepage. I still see 2 <h1>'s

Are you using the theme unit test file, @ianbelanger79. If so, there's a high chance that the second <h1> is coming from the post Markup: HTML Tags and Formatting, which contains <h1> until <h6>. You wrote "static homepage". My bad! 🤦‍♂

[acosmin]

@ianbelanger79 is_page() should take care of is_page_template() and other cases...

[ianbelanger79]

That fixed it