Use HTTPS Protocol #5
Conversation
Just a minor HTTPS tweak.
|
LGTM 👍 |
|
Why not remove the entire line? It's not actually needed these days. |
| ?> |
There was a problem hiding this comment.
There's no reason to have this closing tag, and looking at Twenty Nineteen, it looks like the convention is to omit it at the end of a file.
There was a problem hiding this comment.
@ZebulanStanphill I didn't add that, just changed the protocol :)
There was a problem hiding this comment.
Oh, I see. The closing tag was already there, but your editor added a newline character.
There was a problem hiding this comment.
It's directly via GH, no idea :)
There was a problem hiding this comment.
This repo has a .editorconfig that specifies having a line break at the end of every file, and apparently GitHub has native support for EditorConfig:
editorconfig/editorconfig.github.com#48
So that's probably where it came from.
Just a minor HTTPS tweak. GH/WPORG username: emiluzelac