Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Asterisk block style for separator block #448

Closed
wants to merge 2 commits into from
Closed

Asterisk block style for separator block #448

wants to merge 2 commits into from

Conversation

colorful-tones
Copy link
Member

Description

An alternative to #51 and #365 . This allows the user to choose colors and alignment. All alignments are centered for .alignfull, .alignwide, .aligncenter. If there is no alignment then the asterisk aligns left.

Screenshot 2023-09-20 at 1 37 28 PM

@carolinan
Copy link
Contributor

carolinan commented Sep 20, 2023

It can't be an HR:

  • Doesn't have any screen reader announcement, as it's a decorative element, not semantic

An hr element is announced by screen readers, so I think that's only viable if the asterisk is a legitimate representation of a section break. Most screen readers announce it as 'separator'; VoiceOver announces it as 'horizontal splitter' or 'horizontal separator' depending on browser. So it would still be fairly verbose. The announcement is meaningful, however, as long as the semantics match the usage.

@carolinan carolinan closed this Sep 20, 2023
@carolinan
Copy link
Contributor

Eh I meant to comment not close

@carolinan carolinan reopened this Sep 20, 2023
@colorful-tones
Copy link
Member Author

It can't be an HR

🤦 I missed that.

Eh I meant to comment not close

No worries!

@MaggieCabrera
Copy link
Collaborator

the reason being it's being announced by screen readers and it's not semantically correct

@MaggieCabrera
Copy link
Collaborator

also, does it work as an external image to change colors in chrome? last time I tried it only worked on firefox

@colorful-tones
Copy link
Member Author

also, does it work as an external image to change colors in chrome? last time I tried it only worked on firefox

Yes, the color changing works in both Firefox and Chrome.

@luminuu luminuu closed this Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants