Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Aligns the core/code block border radius with core/image and core/quote blocks #561

Merged
merged 2 commits into from Oct 9, 2023

Conversation

mhkuu
Copy link
Contributor

@mhkuu mhkuu commented Oct 4, 2023

Description

In #519, it was reported that the block border radius for core/code blocks did not match the core/image and core/quote blocks as per the Figma design. This PR fixes that. I've also made sure the Figma design is followed. I've removed the override in styles/ice.json as that did not change any of the styling anymore.

I kept the font family as it was in the default theme. I see Figma uses SF Mono, if we need to add that, perhaps it's better to do that in a separate PR?

Screenshots

Screenshot 2023-10-06 at 16 16 25

Testing Instructions

  1. Activate the theme.
  2. Create a new post.
  3. Add a code block, a quote block, and an image block. Set the image to be rounded.
  4. Confirm the border radius of all of these blocks is the same.
  5. In the site editor, set "icy" as your default theme.
  6. Publish your post and check it in the front-end.
  7. Confirm the code block still has the correct border radius.

Contributors

@mhkuu

Contributed during Yoast Contributor Day on Wednesday 4 October 2023.

Fixes #519.

@luminuu
Copy link
Member

luminuu commented Oct 4, 2023

There are a couple more changes that need to be done besides the border radius, to make the code block look like in the design:

CleanShot 2023-10-04 at 13 10 26@2x

Link to Figma: https://www.figma.com/file/AlYr03vh4dVimwYwQkTdf6/Twenty-Twenty-Four?type=design&node-id=565-9988&mode=design&t=Pq7ws8UJuicCzyUb-4

Do you want to take a look at this and implement the changes in this PR too?

@mhkuu
Copy link
Contributor Author

mhkuu commented Oct 4, 2023

Sure @luminuu, I can continue working on this on Friday!

@mhkuu mhkuu removed their assignment Oct 6, 2023
@mhkuu
Copy link
Contributor Author

mhkuu commented Oct 6, 2023

@luminuu Ready for review! 😸

Copy link
Member

@luminuu luminuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luminuu luminuu merged commit ed4b66c into WordPress:trunk Oct 9, 2023
2 checks passed
@mhkuu mhkuu deleted the fix/core-code-border-radius branch October 9, 2023 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Code Block: Match global styles with the design
2 participants