Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

add a Neo-Grotesque font stack #591

Closed

Conversation

LittleBigThing
Copy link
Contributor

Add a Neo-Grotesque (sans-serif) font stack (based on modernfontstacks.com) as a light-weight alternative for Inter

Example implementation of #572

adding a Neo-Grotesque font stack from modernfontstacks.com as an alternative for Inter
@LittleBigThing LittleBigThing mentioned this pull request Oct 10, 2023
@richtabor
Copy link
Member

We should probably name this something more recognizable, like "System font".

@luminuu
Copy link
Member

luminuu commented Oct 11, 2023

There is a PR for adding the true system font: #573 - I'd prefer that one over this PR here, so we don't have too many system fonts cluttering the interface.

@richtabor
Copy link
Member

Definitely only one. But if we add it to the parent, we'll need it on any variation that overrides fonts I think. Should double-check.

@luminuu
Copy link
Member

luminuu commented Oct 11, 2023

@richtabor Just tested this, we only need to udpate the style variations adding the system fonts if they have fonts declared in the style variation json. If there's no explicit declaration, the fonts from the main theme.json are used. Which means Fossil, Ice, Mint and Sandstorm need to be updated. Onyx and Rust need no work.

@MaggieCabrera
Copy link
Collaborator

Closed in favor of #667

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants