Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Adjust single with sidebar template #604

Merged
merged 10 commits into from Oct 13, 2023
Merged

Conversation

luminuu
Copy link
Member

@luminuu luminuu commented Oct 10, 2023

Description

I've updated the Single with Sidebar template to get the sidebar close to 360 pixels as in the design. It's not exact, but removing the empty columns and adding some extra padding brings it closer to the design. The sidebar is about 340 pixels at max.

Screenshots

CleanShot 2023-10-10 at 19 23 28@2x

Testing Instructions

  1. Checkout this PR
  2. Go to the Site Editor -> Templates
  3. Make sure there are no customizations saved for the "Single with Sidebar" template
  4. Open template to check in the editor
  5. Open a post
  6. Set the template to "Single with Sidebar"
  7. Save post
  8. Open saved post in the frontend

@luminuu luminuu linked an issue Oct 10, 2023 that may be closed by this pull request
Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed an issue where the post title wouldn't be aligned with the featured image and the post content. Thanks for doing this, now the markup is much simpler and it looks closer to the design

@MaggieCabrera MaggieCabrera merged commit 4b651a7 into trunk Oct 13, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Search block on sidebar
2 participants