Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Fix search block styling #103

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Fix search block styling #103

merged 1 commit into from
Sep 25, 2020

Conversation

jffng
Copy link
Collaborator

@jffng jffng commented Sep 21, 2020

This PR addresses a small bug in the way the search block was displayed on the front-end and in the editor.

Before
Screen Shot 2020-09-21 at 4 37 41 PM

After
Screen Shot 2020-09-21 at 4 37 16 PM

@jffng jffng changed the title Fix search block styling bug Fix search block styling Sep 21, 2020
@jffng jffng added the [Type] Bug Something isn't working label Sep 21, 2020
@carolinan
Copy link
Contributor

carolinan commented Sep 22, 2020

I am not able to replicate this error, is this with Gutenberg installed? It would need to be, because of the new controls.
This is what I am seeing:
search-size

@jffng
Copy link
Collaborator Author

jffng commented Sep 22, 2020

I am not able to replicate this error, is this with Gutenberg installed?

Ah you're right — this bug only happens with Gutenberg's latest search block iteration.

@carolinan carolinan mentioned this pull request Sep 22, 2020
5 tasks
@melchoyce
Copy link
Contributor

Does this fix impact existing search blocks in core's version of Gutenberg? If not, let's merge 👍

@carolinan carolinan merged commit 6bddd62 into trunk Sep 25, 2020
@aristath aristath deleted the fix/search-block-display branch October 23, 2020 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants