General cleanup #118
General cleanup #118
Conversation
sync branch with trunk
Updates the style.scss table of content to match the current file structure better. Change comment style in the scss files to reduce out of context comments in the css files. Removes unused CSS, two unused files, and one unused package.json script.
| @@ -1,13 +0,0 @@ | |||
| html { | |||
There was a problem hiding this comment.
This was removed because the same code is in the Reset: https://github.com/WordPress/twentytwentyone/blob/trunk/assets/sass/03-generic/reset.scss#L41
| @@ -11,7 +11,7 @@ Version: 1.0.0 | |||
| License: GNU General Public License v2 or later | |||
| License URI: LICENSE | |||
| Text Domain: twentytwentyone | |||
| Tags: one-column, flexible-header, accessibility-ready, custom-colors, custom-menu, custom-logo, editor-style, featured-images, footer-widgets, rtl-language-support, sticky-post, threaded-comments, translation-ready | |||
There was a problem hiding this comment.
flexible-header was removed because the theme does not comply with the requirements for using this tag.
See https://make.wordpress.org/themes/handbook/review/required/theme-tags/
There was a problem hiding this comment.
Should we add the block-patterns tag while we're here, or we'll do a pass at the end to ensure the theme has accurate tags?
| @@ -1,4 +1,5 @@ | |||
| // Button Placeholder style | |||
| /* Button extends */ | |||
There was a problem hiding this comment.
Do these comments need to make it into the compiled CSS?
| /* Button extends */ | |
| // Button extends |
There was a problem hiding this comment.
Without them in the css file the code felt out of place because there is no heading or explaination to why the button styles are loaded this early.
| word-wrap: break-word; | ||
| } | ||
| */ | ||
| /* Mixins */ |
There was a problem hiding this comment.
| /* Mixins */ | |
| // Mixins |
| @@ -11,7 +11,7 @@ Version: 1.0.0 | |||
| License: GNU General Public License v2 or later | |||
| License URI: LICENSE | |||
| Text Domain: twentytwentyone | |||
| Tags: one-column, flexible-header, accessibility-ready, custom-colors, custom-menu, custom-logo, editor-style, featured-images, footer-widgets, rtl-language-support, sticky-post, threaded-comments, translation-ready | |||
There was a problem hiding this comment.
Should we add the block-patterns tag while we're here, or we'll do a pass at the end to ensure the theme has accurate tags?
General cleanup, replaces #118
For #44
Removes unused CSS for the site footer, two unused files, and one unused package.json script.
Updates the style.scss table of content to match the current file structure better.
Changes some of the comment styles in the scss files.
@luminuu For the SCSS structure, I think the code for the following are still in the wrong files and needs to be moved here: