-
Notifications
You must be signed in to change notification settings - Fork 118
Quote & Pullquote block: Update symbol position #832
Conversation
In a previous PR it was mentioned that the symbol should not have position:absolute but instead be on the previous line: #787 (comment) |
Can figma be updated to match the final design? The editor and front needs to match, no matter wich style that is selected 🙂 |
Is this image with the pr applied? |
No, this is without the PR. |
I suspect that if we change the position of the symbol for the classic/legacy quote, it will also affect the pull quote. I will test shortly. |
Sync branch with trunk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, removes the border & fixes the quote alignment. The linter error in the checks is a false failure, this PR was created before the fix in #847
Partial fix for #549
Fixes #835
Summary
When the quote block has right aligned text:
Hides the original, left aligned quote symbol.
Places a new quote symbol left of the text itself.
Resets the absolute position for the pullquote block so that the symbol is above the text.
c1bf9a9 Fixes the position of the symbol on the front when the text has the default alignment.
Also: Removes the left border that is visible on the default quote on the front.
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
Screenshots
Editor:
Before
After
Front:
Before
After:
It does not fix the position of the symbol for "classic" quotes:
Quality assurance