Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Quote & Pullquote block: Update symbol position #832

Merged
merged 5 commits into from
Nov 20, 2020

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Nov 11, 2020

Partial fix for #549
Fixes #835

Summary

When the quote block has right aligned text:
Hides the original, left aligned quote symbol.
Places a new quote symbol left of the text itself.
Resets the absolute position for the pullquote block so that the symbol is above the text.

c1bf9a9 Fixes the position of the symbol on the front when the text has the default alignment.

Also: Removes the left border that is visible on the default quote on the front.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  1. Add two quotes blocks.
  2. Align one of quotes to the right.
  3. Confirm that the default block and the right aligned block matches, except the text is right aligned.

Screenshots

Editor:
Before
quote-editor

After
quote-editor-after


Front:
Before
quote-front

After:
quote-front-after


It does not fix the position of the symbol for "classic" quotes:
classic-quote-front

Quality assurance

  • I have thought about any security implications this code might add.
  • I have checked that this code doesn't impact performance (greatly).
  • I have tested this code to the best of my abilities
  • I have checked that this code does not affect the accessibility negatively

@carolinan carolinan marked this pull request as ready for review November 11, 2020 12:56
@aristath
Copy link
Member

In a previous PR it was mentioned that the symbol should not have position:absolute but instead be on the previous line: #787 (comment)
Did we decide to place it with postition:absolute instead? 🤔

@carolinan
Copy link
Contributor Author

Can figma be updated to match the final design?

The editor and front needs to match, no matter wich style that is selected 🙂

@melchoyce
Copy link
Contributor

What I'm seeing in the editor looks visually correct for the Quote block:

image

Only the Pullquote block styles should use quotation marks above the quote:

@carolinan
Copy link
Contributor Author

What I'm seeing in the editor looks visually correct for the Quote block:

Is this image with the pr applied?
Because the symbol for the right aligned text is in the wrong position in this image.

@melchoyce
Copy link
Contributor

No, this is without the PR.

@carolinan
Copy link
Contributor Author

I suspect that if we change the position of the symbol for the classic/legacy quote, it will also affect the pull quote. I will test shortly.

@carolinan
Copy link
Contributor Author

Editor: This is copy pasted so ignore the spacing between the blocks.

editor

@carolinan
Copy link
Contributor Author

carolinan commented Nov 12, 2020

Front

I did not include both the left aligned and right aligned solid pull quote in the screenshot, as you can see it is broken, but, this is not related to this pull request:

'front

@carolinan carolinan changed the title Quote block: Update symbol position when right aligned Quote block: Update symbol position Nov 12, 2020
@carolinan carolinan changed the title Quote block: Update symbol position Quote & Pullquote block: Update symbol position Nov 12, 2020
@carolinan carolinan added this to the WordPress RC 1 milestone Nov 12, 2020
Copy link
Collaborator

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, removes the border & fixes the quote alignment. The linter error in the checks is a false failure, this PR was created before the fix in #847

@melchoyce melchoyce merged commit 5338ef6 into trunk Nov 20, 2020
@carolinan carolinan deleted the quote-right-aligned-text branch November 30, 2020 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pullquote: when we select the solid color style then the " (Quote) gets overlap with placeholder #26885
4 participants