Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Add the home page "call to action" / signup pattern #61

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

carolinan
Copy link
Collaborator

Adding this pattern here for now, and we can discuss if it should be in the pattern directory or the theme.

I am concerned the text might indicate to some users that the theme has some sort of newsletter functionality.
Can we come up with something more neutral?

@beafialho
Copy link
Collaborator

I am concerned the text might indicate to some users that the theme has some sort of newsletter functionality.
Can we come up with something more neutral?

Good point, how about this?

Captura de ecrã 2022-08-17, às 10 44 02

I noticed the line height seems a little too large to me, compared to the Figma specs:

Captura de ecrã 2022-08-17, às 10 47 52

@carolinan
Copy link
Collaborator Author

When I updated the text, the question mark was on a third line. So I removed the 40% width of the left column.
That meant that the line did not extend as close to the text as in the design:

Screen Shot 2022-08-17 at 12 10 52

We should probably test with a row block too instead of a columns block.

@carolinan
Copy link
Collaborator Author

I tested a row with a stack with the paragraph and button on the left, and the separator on the right, and it did not work, the separator is invisible.

row block with nested blocks

@beafialho
Copy link
Collaborator

When I updated the text, the question mark was on a third line. So I removed the 40% width of the left column.
That meant that the line did not extend as close to the text as in the design:

Thank you, I think that's ok.

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🚢

@carolinan carolinan merged commit d62bef9 into trunk Aug 19, 2022
@carolinan carolinan deleted the add/home-pattern branch August 19, 2022 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants