-
Notifications
You must be signed in to change notification settings - Fork 65
Update navigation and site title styles #83
Conversation
In post content: All text links that can be added to the navigation block are underlined by default in the editor, except the site title block. -This is different from the front where the underline is hidden in the default state. If I turn on "open on click": |
Some things I noticed:
hovers.mp4
posttitles.mp4
Those are supposed to be black. Only links in paragraphs are intended be green. |
Thanks for testing @carolinan!
I can't see this in my local editor. I'll keep an eye on this and check for any related GB issues.
I can see this. I think I've fixed it by removing underlines by default on the navigation block.
I see this too - I can't seem to fix it with additional settings in theme.json, I'll find/open an upstream issue.
I can't see this either, this sounds similar to the first issue you listed. It could totally be my environment! |
Thanks @beafialho!
This should now be the case with every other block other than navigation and navigation-link.
This should be done. |
Thanks @mikachan, I see those changes now! |
I've updated this PR so the links should now match the designs from here. |
This PR moves the link styles from the child
navigation-link
block to the parentnavigation
block.It also replicates these link styles on the
site-title
block, so that the site title link states match the navigation link states.Closes #74.