Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Update navigation and site title styles #83

Merged
merged 7 commits into from
Aug 24, 2022
Merged

Conversation

mikachan
Copy link
Member

This PR moves the link styles from the child navigation-link block to the parent navigation block.

It also replicates these link styles on the site-title block, so that the site title link states match the navigation link states.

Closes #74.

@mikachan mikachan added the [Type] Enhancement New feature or request label Aug 19, 2022
theme.json Show resolved Hide resolved
@carolinan
Copy link
Collaborator

carolinan commented Aug 22, 2022

In post content:
The page list block, home link, site title and the submenu block have the green link color on the front, but not in the editor where they are black.
The navigation link and page link are black in both views.

All text links that can be added to the navigation block are underlined by default in the editor, except the site title block. -This is different from the front where the underline is hidden in the default state.

If I turn on "open on click":
Parent items that have sub menus are not underlined on hover anymore -they are buttons. As a user I would expect the menu to look the same when I enable this option.
Parent items in the page list block has a black text color but the sub menu item links are green.

@beafialho
Copy link
Collaborator

Some things I noticed:

  • Site title and nav links hover states are looking good.
  • The reverse should happen when we hover any underlined link by default (paragraph link, categories, tags, log in to comment, credit in the footer and so on).
hovers.mp4
  • Post titles currently have no underline by default but they should show an underline when we hover them.
posttitles.mp4

The navigation link and page link are black in both views.

Those are supposed to be black. Only links in paragraphs are intended be green.

@mikachan
Copy link
Member Author

Thanks for testing @carolinan!

The page list block, home link, site title and the submenu block have the green link color on the front, but not in the editor where they are black.

I can't see this in my local editor. I'll keep an eye on this and check for any related GB issues.

All text links that can be added to the navigation block are underlined by default in the editor, except the site title block. -This is different from the front where the underline is hidden in the default state.

I can see this. I think I've fixed it by removing underlines by default on the navigation block.

Parent items that have sub menus are not underlined on hover anymore -they are buttons. As a user I would expect the menu to look the same when I enable this option.

I see this too - I can't seem to fix it with additional settings in theme.json, I'll find/open an upstream issue.

Parent items in the page list block has a black text color but the sub menu item links are green.

I can't see this either, this sounds similar to the first issue you listed. It could totally be my environment!

@mikachan
Copy link
Member Author

Thanks @beafialho!

The reverse should happen when we hover any underlined link by default (paragraph link, categories, tags, log in to comment, credit in the footer and so on).

This should now be the case with every other block other than navigation and navigation-link.

Post titles currently have no underline by default but they should show an underline when we hover them.

This should be done.

@beafialho
Copy link
Collaborator

Thanks @mikachan, I see those changes now!

@mikachan
Copy link
Member Author

I've updated this PR so the links should now match the designs from here.

@mikachan mikachan merged commit 0a61ced into trunk Aug 24, 2022
@mikachan mikachan deleted the update/nav-styles branch August 24, 2022 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply the navigation block styles to the sub menu block and home link
3 participants