Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Beta 2 - changing font size of links in Styles changes all link font sizes #286

Closed
mjsdiaz opened this issue Dec 8, 2021 · 4 comments
Closed
Labels
[Type] Bug Something isn't working

Comments

@mjsdiaz
Copy link

mjsdiaz commented Dec 8, 2021

Describe the bug

  1. If the font size of Styles > Typography > Links is changed, all links regardless of type pick up that font size.
    This includes Blocks such as the Post Title (with Make title a link) and the Post Date (with Link to post)

The Post Title link and Post Date link should not pick up the size assigned under Styles > Typography > Links; they should keep the size assigned in Theme.json or assigned to the individual block.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Appearance > Editor'
  2. Click on 'Post Title' or 'Post Date' - Both are links
  3. When on the Block and Settings, Scroll down to 'Typography' > Size.
  4. The font sizes change as expected.
  5. Go to Styles > Typography > Links
  6. Change the font size.
  7. All links, Paragraph, Post Title, and Post Date change size.
  8. Go back to each block (Post Title or Post Date) and try to change the font size.
  9. Error: The font size won't change, when I would expect to be able to change the Post Title font size regardless of whether it's a link or not.

Expected behavior
The font size set on the block Typography should change the size of the Post Title or Post Date regardless of whether it's a link or not, and regardless of whether a font size has been set under Styles > Typography > Links.

Screenshots
If applicable, add screenshots to help explain your problem.

Device: Mac Mini
OS: Mac OS Big Sur 11.6
Browser: Chrome iVersion 96.0.4664.55 (Official Build) (x86_64) and FireFox 94.0.2 (64bit)

Additional context

@mjsdiaz mjsdiaz added the [Type] Bug Something isn't working label Dec 8, 2021
@jffng
Copy link
Collaborator

jffng commented Dec 9, 2021

Thanks for the report @mjsdiaz. I was able to replicate this in TT2. I also tested this in emptytheme, and the issue occurs there too, so it doesn't appear to be TT2-specific.

I will file a follow up issue upstream in Gutenberg and link it here.

@kjellr
Copy link
Collaborator

kjellr commented Dec 9, 2021

I'm not sure it even makes sense to have a font-size option for links. 🤷

@mjsdiaz
Copy link
Author

mjsdiaz commented Dec 9, 2021

Thank you for confirming and passing it on, @jffng.

I agree that links do not need their own size setting; they should pick up the size of the block they are in. I always wondered about that setting in theme.json, @kjellr

@kjellr
Copy link
Collaborator

kjellr commented Dec 9, 2021

Thanks! I'm going to close this now that it's been reported upstream.

@kjellr kjellr closed this as completed Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants