This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Fix duplicate block pattern #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
commented
Nov 19, 2021
| @@ -1,84 +1,26 @@ | |||
| <?php | |||
There was a problem hiding this comment.
This diff looks deceptively complex. This pattern is being replaced with the one that was previously in the footer-title-tagline-social-dark.php file, so that's why it looks like so much has changed.
jffng
reviewed
Nov 19, 2021
inc/block-patterns.php
Outdated
| 'page-about-media-left', | ||
| 'page-about-simple-dark', | ||
| 'page-about-media-right', | ||
| 'page-about-links', | ||
| 'page-about-links-dark', | ||
| 'page-about-big-image-and-buttons', |
There was a problem hiding this comment.
Should the file be renamed to page-about-large-image-and-buttons for consistency?
There was a problem hiding this comment.
Good call! I'll make that change and merge. 👍
jffng
approved these changes
Nov 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our "About page with big image and buttons" pattern is showing up as a duplicate in the footer category by mistake, with the title "Footer with title, tagline, and social links". I think this was an error from duplicating files back when I was creating new patterns:
This PR removes that pattern, and tidies up the naming of the actual "Footer with title, tagline, and social links" pattern. It also renames "About page with big image and buttons" to use the word "large" instead of "big" because that's more consistent with language we're using elsewhere.
Finally, since I was editing it anyway, I moved the "About page with big image and buttons" pattern down the list so that it's next to our other "link in bio"-style patterns.