This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Use --wp--custom--spacing--small instead of hard-coded spacing styles #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #309 and closes #317 by using
var(--wp--custom--spacing--small, 1.25rem)
in place of the hard-codedmax(1.25rem, 5vw)
styles within patterns. This way if a user modifies the theme's theme.jsonsettings.custom.spacing.small
value, it is reflected throughout the theme.Testing Instructions
settings.custom.spacing.small
valuemax(1.25rem, 5vw)
values are hard-coded into the patternssettings.custom.spacing.small
value in theme.json